Update MSRV to 1.77.0#8796
Merged
Merged
Conversation
This accompanies today's release of Rust 1.79.0. This means that CI will now use the latest stable of 1.79.0 for testing primarily. Additionally this updates the pinned nightly commit used for testing to today's nightly and fixes a few warnings that uncovered. I plan on having a follow-up that leverages some new APIs and features in 1.77.0.
alexcrichton
requested review from
abrown and
elliottt
and removed request for
a team
alexcrichton
commented
Jun 13, 2024
| if cfg!(all(target_os = "macos", target_arch = "aarch64")) { | ||
| assert_eq!(isa.default_call_conv(), CallConv::AppleAarch64); | ||
| } else if cfg!(any(unix, target_os = "nebulet")) { | ||
| } else if cfg!(unix) { |
Member
Author
There was a problem hiding this comment.
This change is because rustc now warns that target_os = "nebulet" doesn't exist. I think that means the target was probably removed here. I don't know what nebulet is myself, though, so I'm just obeying rustc.
elliottt
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accompanies today's release of Rust 1.79.0. This means that CI will now use the latest stable of 1.79.0 for testing primarily. Additionally this updates the pinned nightly commit used for testing to today's nightly and fixes a few warnings that uncovered. I plan on having a follow-up that leverages some new APIs and features in 1.77.0.